This repository was archived by the owner on Mar 19, 2019. It is now read-only.
Move from statsd-node to node-statsd and use tags.#363
Merged
Conversation
Natim
force-pushed
the
move-to-node-statsd-with-tags
branch
from
dc79a4e to
d146e7c
Compare
| }, function(err) { | ||
| var status = 'success'; | ||
| if (err) { | ||
| self.logError(err); |
Contributor
There was a problem hiding this comment.
Nit: not introduced by this patch by you should probably set the third argument of forEach to instead instead of relying on self in this whole loop.
Contributor
|
The patch looks good to me with some nits here and there, so from a code standpoint and as the tests are green, r+wc. Note: I know basically nothing about the Loop production server infrastructure and its constraints, but I wonder about a possible backward compatibility issue with the renamed log events though. |
loop/routes/home.js
Outdated
| tag = 'failure'; | ||
| } | ||
| statsdClient.count(counter_push_status_counter, 1); | ||
| statsdClient.increment('loop.simplepush.call', 1, [tag]); |
Contributor
There was a problem hiding this comment.
do we really want to remove the "heartbeat" part ?
Contributor
Author
This is something @kparlante and @Micheletto should be notified about. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feedback? @Standard8 @Micheletto
r? @tarekziade @n1k0